Fix remaining dep warns.

JuliaIO / MeshIO.jl

IO for Meshes

Other

79 stars 31 forks source link

Fix remaining dep warns. #24

Closed musm closed 7 years ago

musm commented 7 years ago

Forgot these...

musm commented 7 years ago

On a side note it would be nice to get rid of FactCheck and use Base.Test. Not sure how we could still use v0.5 Base.Test features on v0.4 ?

coveralls commented 7 years ago

Coverage remained the same at 96.364% when pulling 3eb57e329f34c6619195613801a64ca552b5cc1a on musm:fixdep into 792bceca46bb8f76efa540abf3086d6a0d86d93f on JuliaIO:master.

codecov-io commented 7 years ago

Current coverage is 96.36% (diff: 100%)

Merging #24 into master will not change coverage

@@             master        #24   diff @@
==========================================
  Files             6          6          
  Lines           275        275          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            265        265          
  Misses           10         10          
  Partials          0          0

Powered by Codecov. Last update 792bcec...3eb57e3

SimonDanisch commented 7 years ago

On a side note it would be nice to get rid of FactCheck and use Base.Test. Not sure how we could still use v0.5 Base.Test features on v0.4 ?

Good idea! I think BaseTestNext can be used for that purpose!

SimonDanisch commented 7 years ago

Appveyor test failure is due to FixedSizeArrays which got fixed but not tagged yet! Thanks!