search

JuliaIO / MeshIO.jl

IO for Meshes
Other
79 stars 32 forks source link

Fixes for Julia v0.6 and GeometryTypes 0.4 #31

Closed rdeits closed 7 years ago

rdeits commented 7 years ago

cc @SimonDanisch I think I added enough .+ 1s everywhere 😉

rdeits commented 7 years ago

This requires https://github.com/JuliaGeometry/GeometryTypes.jl/pull/93 and https://github.com/JuliaGeometry/GeometryTypes.jl/pull/91

rdeits commented 7 years ago

Failures on nightly are a Julia bug: https://github.com/JuliaLang/julia/issues/22179

SimonDanisch commented 7 years ago

Wait, have you actually seen: https://github.com/JuliaIO/MeshIO.jl/tree/sd/staticarrays

rdeits commented 7 years ago

Derp, no, I hadn't

SimonDanisch commented 7 years ago

Sorry for not making it more obvious... I'm a bit behind maintaining all these packages -.-

rdeits commented 7 years ago

No problem. I've updated this branch again to be compatible with https://github.com/JuliaGeometry/GeometryTypes.jl/pull/97 . I think the use of reinterpret() here helps a lot with clarifying what's going on (and saves two whole additions, too! :wink: )

rdeits commented 7 years ago

Is this OK to merge? I'd like to get the GeometryTypes mesh ecosystem working in time for JuliaCon 😄

rdeits commented 7 years ago

thanks!