Fix if-else sequence - Githubissues

JuliaIO / MeshIO.jl

IO for Meshes

Other

79 stars 31 forks source link

Fix if-else sequence #37

Closed Gnimuc closed 6 years ago

Gnimuc commented 6 years ago

Since contains("f 1//1 2//2 3//3", "/") returns true, the face normal(process_face_normal) block may never be executed. I don't know whether this will affect other cases, @SimonDanisch please give a review at your convenience. 😉

rdeits commented 6 years ago

Oops, I just realized this is a duplicate of the PR I just opened in #38

SimonDanisch commented 6 years ago

Let's merge @rdeits PR that has tests! Thanks for your contribution @Gnimuc, really sorry I forgot about this PR!

Gnimuc commented 6 years ago

never mind 😄