search

JuliaIO / MeshIO.jl

IO for Meshes
Other
79 stars 31 forks source link

Add `save(f::Stream{format"STL_BINARY"}, msh::AbstractMesh)` #4

Closed dhoegh closed 8 years ago

dhoegh commented 9 years ago

Add exportBinaryStl function and rename exportStl to exportAsciiSTL for consistency, this has been moved from JuliaGeometry/Meshes.jl/pull/41. How about test of the implementation, the STL module do not seem to be hooked up to the package yet? Add save(f::Stream{format"STL_BINARY"}, msh::AbstractMesh) + test, bug fixes in loading and saving stl files and activate the CI to test both 0.4 and nightly

dhoegh commented 8 years ago

I finally came around to rebase this as the save binary stl file is removed from meshes and the functionality do not seem to have migrated here. The failure is due to https://github.com/JuliaGeometry/GeometryTypes.jl/issues/36. I have found what seems to be two bugs in saving and loading stl files. I have seperated them in a commit. While investigating the CI failure I also saw that Travis is only activated for 0.4 and Appveyor for nightly. I have activated so the CI's test both 0.4 and nightly.

SimonDanisch commented 8 years ago

Thanks for doing this =) this should be fixed on master, although incompatible with earlier GeometryType versions... maybe time for tagging!

dhoegh commented 8 years ago

I have rebased the PR on master.

dhoegh commented 8 years ago

Bump, could this be merged the implementation have been a part of meshes.jl and it fixes some bugs.

SimonDanisch commented 8 years ago

Oh, this hid away in my periphery. Thanks again!

tkelman commented 8 years ago

This looks like it's failing tests on 0.4 after being merged?

SimonDanisch commented 8 years ago

Indeed, thanks! I was sure that this was because the other packages weren't tagged, but I can reproduce this localy, now!