search

JuliaIO / MeshIO.jl

IO for Meshes
Other
79 stars 31 forks source link

fix all deprecation warnings on julia v0.7 #41

Closed rdeits closed 5 years ago

rdeits commented 5 years ago

This fixes all deprecation warnings on Julia v0.7, and updates the minimum Julia version to v0.7-alpha.

All of the tests pass locally for me with StaticArrays master, https://github.com/JuliaIO/FileIO.jl/pull/190 and https://github.com/JuliaGeometry/GeometryTypes.jl/pull/134 . We might want to wait until those get merged and tagged before merging this.

I also added some more tests to try to make sure we don't have any OffsetInteger bugs.

SimonDanisch commented 5 years ago

https://github.com/JuliaLang/METADATA.jl/pull/15497 https://github.com/JuliaLang/METADATA.jl/pull/16061

rdeits commented 5 years ago

OK to merge once CI passes?

SimonDanisch commented 5 years ago

Yes go for it :)

rdeits commented 5 years ago

Oh, whoops, I don't have access to merge this. Could you click the merge button?

SimonDanisch commented 5 years ago

thanks!