Closed ffreyer closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
master@7f157db
). Click here to learn what that means. The diff coverage is100.00%
.:exclamation: Current head b451911 differs from pull request most recent head 7f3c39e. Consider uploading reports for the commit 7f3c39e to get more accurate results
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage ? 93.70%
=========================================
Files ? 8
Lines ? 413
Branches ? 0
=========================================
Hits ? 387
Misses ? 26
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
src/io/obj.jl | 96.77% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7f157db...7f3c39e. Read the comment docs.
Btw
┌ Warning: `File(format"PLY_ASCII", filename)` is deprecated, please use `File{format"PLY_ASCII"}(filename)` instead.
│ caller = macro expansion at runtests.jl:37 [inlined]
└ @ Core ~/build/JuliaIO/MeshIO.jl/test/runtests.jl:37
┌ Warning: `File(format"PLY_BINARY", filename)` is deprecated, please use `File{format"PLY_BINARY"}(filename)` instead.
│ caller = macro expansion at runtests.jl:41 [inlined]
└ @ Core ~/build/JuliaIO/MeshIO.jl/test/runtests.jl:41
┌ Warning: `File(format"STL_ASCII", filename)` is deprecated, please use `File{format"STL_ASCII"}(filename)` instead.
│ caller = macro expansion at runtests.jl:44 [inlined]
└ @ Core ~/build/JuliaIO/MeshIO.jl/test/runtests.jl:44
┌ Warning: `File(format"STL_BINARY", filename)` is deprecated, please use `File{format"STL_BINARY"}(filename)` instead.
│ caller = macro expansion at runtests.jl:47 [inlined]
└ @ Core ~/build/JuliaIO/MeshIO.jl/test/runtests.jl:47
┌ Warning: `File(format"STL_BINARY", filename)` is deprecated, please use `File{format"STL_BINARY"}(filename)` instead.
│ caller = (::var"#2#4")(::String) at runtests.jl:74
└ @ Main ~/build/JuliaIO/MeshIO.jl/test/runtests.jl:74
Thanks!
Also fix load for faces like
f 1 2 3
and faces with 2 indices (i.e. position and uv or normal)