JuliaIO / MeshIO.jl

IO for Meshes
Other
79 stars 31 forks source link

Support Julia 1.3 #76

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

MeshIO holds back GeometryBasics (and hence also GridLayoutBase) in the tests of Makie with Julia 1.3 (https://github.com/JuliaPlots/Makie.jl/pull/1244). CI should reveal any potential issues with Julia 1.3 🙂

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (d0a131e) into master (97ce3af) will decrease coverage by 0.27%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   93.44%   93.17%   -0.28%     
==========================================
  Files           8        8              
  Lines         412      410       -2     
==========================================
- Hits          385      382       -3     
- Misses         27       28       +1     
Impacted Files Coverage Δ
src/MeshIO.jl 100.00% <100.00%> (ø)
src/io/obj.jl 96.77% <100.00%> (ø)
src/precompile.jl 0.00% <0.00%> (-27.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2f269e...d0a131e. Read the comment docs.

devmotion commented 2 years ago

Test errors look similar to https://github.com/JuliaIO/FileIO.jl/issues/345, maybe it's an issue upstream. I'll investigate it more closely when I'm back at my computer.

devmotion commented 2 years ago

Tests pass now with Julia 1.3. The problem was that filter(f, ::Tuple) is not defined in Julia 1.3. I used the opportunity to clean the list of imports and fix the deprecations in the tests as well.

devmotion commented 2 years ago

@SimonDanisch The PR is ready for review :slightly_smiling_face:

SimonDanisch commented 2 years ago

Thank you :)