Closed ffreyer closed 1 day ago
Attention: Patch coverage is 72.24880%
with 58 lines
in your changes missing coverage. Please review.
Project coverage is 74.72%. Comparing base (
9f452ff
) to head (8666d91
). Report is 28 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
src/io/obj.jl | 76.28% | 46 Missing :warning: |
src/io/ifs.jl | 0.00% | 6 Missing :warning: |
src/io/gts.jl | 0.00% | 5 Missing :warning: |
src/io/ply.jl | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Added the Sponza model from https://casual-effects.com/data/ with only two of the groups/sub-meshes present and all textures removed. That should be enough to test correct loading of group names, "usemtl" tags,mesh.views
and some mtl file parsing, without excessive bulk.
This is a breaking change, that changes the load method:
Oh, true. I didn't have that type at some stages of doing the refactor, so I probably change it then. But I think this is also more in line with other load methods
obj, ply, stl, msh, off and 2DM use this already
(I moved the branch to MeshIO for this one)
Changes for https://github.com/JuliaGeometry/GeometryBasics.jl/pull/219
TODO:
Closes #94 (materials, face groups/objects now loaded with obj files) Fixes #80