Closed magister-ludi closed 1 year ago
Base: 93.26% // Head: 93.67% // Increases project coverage by +0.40%
:tada:
Coverage data is based on head (
7d010a8
) compared to base (d516dd8
). Patch coverage: 95.45% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Sorry to bother busy people, should I merge this, or would someone like to review it? Perhaps @timholy or @johnnychen94 are the most relevant reviewers?
I'll add the compat entry. I notice the build fails for Julia 1.0, because isnothing
is undefined. Is it better to change the compat value for Julia (not sure when isnothing
was added) or revert to ===nothing
?
I should have merge permission when it's all ready.
Oh, you can add a compat definition to fix this. There's no need to bump julia compat for such trivial cases.
if VERSION < v"1.1"
isnothing(x) = x === nothing
end
All tests are passing. Merge now includes version update.
It appears that I don't have permission to merge: there is no "Merge pull request" button. Would you merge please, @johnnychen94
I have also incremented the minor version number, so that needs to be registered.
The
save
methods now accept arguments of typeImageMeta
from ImageMetadata.jl. The properties in objects are saved as comments in the image files.Tests for reading and writing files with and without metadata have been added.
This adds to the dependencies of
Netpbm.jl
, which might be a reason to reject these changes.