JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 55 forks source link

Remove indexing-lookup that cancel each other #183

Closed blegat closed 3 years ago

blegat commented 3 years ago

Currently, the code has the index, it computes the name with objmeta.oneof_names[nameidx] and then find the index from the name in which_oneof (which is the same index as what we had at the beginning, isn't it ?) and ends up calling _which_oneof. In this PR, this is changed to directly call _which_oneof.

tanmaykm commented 3 years ago

Yes, looks good to me. Thanks!