search

JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 55 forks source link

Allow trailing semicolon after `oneof` fields #215

Closed Drvi closed 2 years ago

Drvi commented 2 years ago

Fixes https://github.com/JuliaIO/ProtoBuf.jl/issues/211#issuecomment-1241219281

codecov[bot] commented 2 years ago

Codecov Report

Merging #215 (bb81b7c) into master (f363948) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          25       25           
  Lines        2792     2793    +1     
=======================================
+ Hits         2485     2486    +1     
  Misses        307      307
Impacted Files Coverage Δ
src/parsing/proto_types.jl 91.28% <100.00%> (+0.03%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Drvi commented 2 years ago

Seems like JET is having some issues on nightly, but unrelated to this change.