JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 55 forks source link

a few small fixes for codegen #221

Closed ExpandingMan closed 1 year ago

ExpandingMan commented 1 year ago

This PR includes a few small fixes;

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.04% // Head: 89.04% // No change to project coverage :thumbsup:

Coverage data is based on head (a6577ca) compared to base (787898a). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #221 +/- ## ======================================= Coverage 89.04% 89.04% ======================================= Files 25 25 Lines 2794 2794 ======================================= Hits 2488 2488 Misses 306 306 ``` | [Impacted Files](https://codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/codegen/names.jl](https://codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/221/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2NvZGVnZW4vbmFtZXMuamw=) | `100.00% <100.00%> (ø)` | | | [src/codegen/toplevel\_definitions.jl](https://codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/221/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2NvZGVnZW4vdG9wbGV2ZWxfZGVmaW5pdGlvbnMuamw=) | `96.50% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Drvi commented 1 year ago

Thanks for your contribution! Nice improvement:)