Closed ExpandingMan closed 1 year ago
Base: 89.04% // Head: 89.04% // No change to project coverage :thumbsup:
Coverage data is based on head (
a6577ca
) compared to base (787898a
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for your contribution! Nice improvement:)
This PR includes a few small fixes;
Array
,Vector
,Dict
,Union
andOneOf
. These are names which, if used, would break the generated code because theirBase
names are used without any accommodation to qualify the names in those cases. Ideally I'd like to add a whole lot more (every exported type fromBase
) as they can lead to nasty surprises even if they don't technically break the generated code, but technically adding any other reserved words would be breaking, whereas this PR is not.struct
which inherits fromAbstractProtoBufMessage
. This would lead to broken code such asstruct A <: AbstractProtoBufMessageend
. I have added a unit test for this case.using EnumX
in code generation is nowusing ProtoBuf.EnumX
which uses theEnumX
belonging toProtoBuf
obviating the need for packages using protobuf to includeEnumX
in their environment. Using indirect dependencies is a discouraged practice, however I think it makes sense in this case since the generated code is a bit like internal module code in that it may depend on internal details of the module.