JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 55 forks source link

Possibility to generate mutable struct with an added "mutable" MessageOption #230

Closed SilverGhostBS closed 1 month ago

SilverGhostBS commented 1 year ago

Hi,

I don't even know if this is the proper way to achieve this as I'm very new to Julia, but it seems to work fine, at least on the generation side, I hope it won't cause issues with the encoder/decoder later.

In my project I needed to be able to specify some messages to be generated as mutable.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.03 :warning:

Comparison is base (0d1ef44) 91.51% compared to head (0a3d28b) 91.48%.

:exclamation: Current head 0a3d28b differs from pull request most recent head cd3ddb4. Consider uploading reports for the commit cd3ddb4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #230 +/- ## ========================================== - Coverage 91.51% 91.48% -0.03% ========================================== Files 25 25 Lines 2816 2818 +2 ========================================== + Hits 2577 2578 +1 - Misses 239 240 +1 ``` | [Impacted Files](https://codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/codegen/toplevel\_definitions.jl](https://codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2NvZGVnZW4vdG9wbGV2ZWxfZGVmaW5pdGlvbnMuamw=) | `97.24% <66.66%> (-0.67%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.