JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 55 forks source link

Remove invalid escape sequence #232

Closed c42f closed 1 year ago

c42f commented 1 year ago

Found as part of testing for JuliaLang/julia#46372 - JuliaSyntax.jl rejects \777 as this is above the maximum octal value for a UInt8.

The reference parser incorrectly saturates such invalid char literals to \xff and you've already got a test for that.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.04 :warning:

Comparison is base (0d1ef44) 91.51% compared to head (834a2b7) 91.47%.

:exclamation: Current head 834a2b7 differs from pull request most recent head 75fe33a. Consider uploading reports for the commit 75fe33a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ========================================== - Coverage 91.51% 91.47% -0.04% ========================================== Files 25 25 Lines 2816 2816 ========================================== - Hits 2577 2576 -1 - Misses 239 240 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/JuliaIO/ProtoBuf.jl/pull/232/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.