search

JuliaIO / ProtoBuf.jl

Julia protobuf implementation
Other
205 stars 56 forks source link

Test tweaks #245

Closed Drvi closed 10 months ago

Drvi commented 10 months ago

We use reflection to traverse generated structs in tests that relied on Vectors not having any fields, this changed on master so we tweaked the logic to reflect that.

Also, codec tests were tweaked to always generate new Julia definitions instead of hard-coding them manually. While doing that I noticed that "struct" was not treated as a reserved keyword, but it should be as it cannot appear as an identifier or a field name.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (97f55ed) 92.34% compared to head (18539db) 92.46%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #245 +/- ## ========================================== + Coverage 92.34% 92.46% +0.12% ========================================== Files 25 25 Lines 2807 2812 +5 ========================================== + Hits 2592 2600 +8 + Misses 215 212 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.