Closed timholy closed 3 years ago
Merging #123 (521e571) into master (ffb3dd5) will increase coverage by
0.30%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 96.53% 96.84% +0.30%
==========================================
Files 4 4
Lines 722 729 +7
==========================================
+ Hits 697 706 +9
+ Misses 25 23 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/extract.jl | 97.97% <100.00%> (+0.28%) |
:arrow_up: |
src/header.jl | 94.44% <0.00%> (+1.48%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ffb3dd5...521e571. Read the comment docs.
Actually, the original fix isn't complete: now, a smaller number of invalidations happen due to https://github.com/SciML/Static.jl/blob/bf61620eeeb0ca0d66be5fb6fe0838f6f85bf200/src/int.jl#L26.
But it looks like the value-types of paths
are always String
, Symbol
, or Int64
, so that makes life easier.
These get invalidated by loading Static.jl, specifically the method
CC @ChrisRackauckas