search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
79 stars 19 forks source link

Fix ~160 invalidations from partially-inferred kwargs to `Header` #123

Closed timholy closed 3 years ago

timholy commented 3 years ago

These get invalidated by loading Static.jl, specifically the method

Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N)

CC @ChrisRackauckas

codecov[bot] commented 3 years ago

Codecov Report

Merging #123 (521e571) into master (ffb3dd5) will increase coverage by 0.30%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   96.53%   96.84%   +0.30%     
==========================================
  Files           4        4              
  Lines         722      729       +7     
==========================================
+ Hits          697      706       +9     
+ Misses         25       23       -2
Impacted Files Coverage Δ
src/extract.jl 97.97% <100.00%> (+0.28%) :arrow_up:
src/header.jl 94.44% <0.00%> (+1.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb3dd5...521e571. Read the comment docs.

timholy commented 3 years ago

Actually, the original fix isn't complete: now, a smaller number of invalidations happen due to https://github.com/SciML/Static.jl/blob/bf61620eeeb0ca0d66be5fb6fe0838f6f85bf200/src/int.jl#L26.

But it looks like the value-types of paths are always String, Symbol, or Int64, so that makes life easier.