fix invalidations from Static.jl

[ranocha]

This should hopefully fix quite some invalidations coming from Static.jl.

Here is the code:

```julia _ _ _ _(_)_ | Documentation: https://docs.julialang.org (_) | (_) (_) | _ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help. | | | | | | |/ _` | | | | |_| | | | (_| | | Version 1.8.0 (2022-08-17) _/ |\__'_|_|_|\__'_| | Official https://julialang.org/ release |__/ | (@v1.8) pkg> activate --temp (jl_PDrBpd) pkg> add Static Updating registry at `~/.julia/registries/General.toml` Resolving package versions... Updating `/tmp/jl_PDrBpd/Project.toml` [aedffcd0] + Static v0.7.6 Updating `/tmp/jl_PDrBpd/Manifest.toml` [615f187c] + IfElse v0.1.1 [aedffcd0] + Static v0.7.6 julia> using SnoopCompileCore julia> invalidations = @snoopr using Static julia> using SnoopCompile julia> trees = invalidation_trees(invalidations) 7-element Vector{SnoopCompile.MethodInvalidations}: ... inserting !(::False) in Static at ~/.julia/packages/Static/sVI3g/src/Static.jl:427 invalidated: ... 158: signature Tuple{typeof(!), Any} triggered MethodInstance for Tar.var"#read_tarball#47"(::Vector{UInt8}, ::Base.DevNull, ::typeof(Tar.read_tarball), ::Function, ::Function, ::Base.Process) (48 children) ```

Since

• !predicate is used here in an if stament - and if statements only accept Bools
• and it is documented that predicate has to return a Bool

it appears to be sane to assert that predicate returns a Bool here.

[codecov[bot]]

Codecov Report

Merging #140 (f95e811) into master (5606269) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files           4        4           
  Lines         775      775           
=======================================
  Hits          754      754           
  Misses         21       21           

Impacted Files	Coverage Δ
src/extract.jl	98.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ranocha]

I suggest the labels latency and backport-1.8 for this PR.

[ranocha]

Bump. Can we get this into Julia v1.8.1?

[ranocha]

Bump. Can we get this into Julia v1.8.1?