JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
80 stars 19 forks source link

transform some recursive closures into normal functions #151

Closed KristofferC closed 1 year ago

KristofferC commented 1 year ago

Recursive closures unfortunately means that the closure gets boxed and we get bad inference.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.37% // Head: 96.25% // Decreases project coverage by -1.12% :warning:

Coverage data is based on head (46ba6ec) compared to base (6bfc114). Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ========================================== - Coverage 97.37% 96.25% -1.13% ========================================== Files 4 4 Lines 801 801 ========================================== - Hits 780 771 -9 - Misses 21 30 +9 ``` | [Impacted Files](https://codecov.io/gh/JuliaIO/Tar.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/extract.jl](https://codecov.io/gh/JuliaIO/Tar.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2V4dHJhY3Quamw=) | `96.29% <33.33%> (-1.86%)` | :arrow_down: | | [src/header.jl](https://codecov.io/gh/JuliaIO/Tar.jl/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2hlYWRlci5qbA==) | `92.00% <0.00%> (-1.34%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.