search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
80 stars 19 forks source link

Fix some issues found by JET #162

Closed StefanKarpinski closed 12 months ago

StefanKarpinski commented 12 months ago

With these changes if you run JET on Julia master, Tar passes:

julia> import JET; JET.report_package("Tar")
[toplevel-info] virtualized the context of Main (took 0.006 sec)
[toplevel-info] entered into /Users/stefan/dev/Tar/src/Tar.jl
[toplevel-info] entered into /Users/stefan/dev/Tar/src/header.jl
[toplevel-info]  exited from /Users/stefan/dev/Tar/src/header.jl (took 0.022 sec)
[toplevel-info] entered into /Users/stefan/dev/Tar/src/create.jl
[toplevel-info]  exited from /Users/stefan/dev/Tar/src/create.jl (took 0.043 sec)
[toplevel-info] entered into /Users/stefan/dev/Tar/src/extract.jl
[toplevel-info]  exited from /Users/stefan/dev/Tar/src/extract.jl (took 0.069 sec)
[toplevel-info]  exited from /Users/stefan/dev/Tar/src/Tar.jl (took 0.196 sec)
[toplevel-info] analyzing from top-level definitions (201/201)
[toplevel-info] analyzed 201 top-level definitions (took 0.26 sec)
No errors detected
codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (6c51ea7) 97.27% compared to head (98037b5) 97.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #162 +/- ## ========================================== + Coverage 97.27% 97.28% +0.01% ========================================== Files 4 4 Lines 807 810 +3 ========================================== + Hits 785 788 +3 Misses 22 22 ``` | [Files Changed](https://app.codecov.io/gh/JuliaIO/Tar.jl/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO) | Coverage Δ | | |---|---|---| | [src/Tar.jl](https://app.codecov.io/gh/JuliaIO/Tar.jl/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL1Rhci5qbA==) | `91.34% <ø> (ø)` | | | [src/create.jl](https://app.codecov.io/gh/JuliaIO/Tar.jl/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2NyZWF0ZS5qbA==) | `100.00% <100.00%> (ø)` | | | [src/extract.jl](https://app.codecov.io/gh/JuliaIO/Tar.jl/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaIO#diff-c3JjL2V4dHJhY3Quamw=) | `98.15% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.