search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
80 stars 19 forks source link

Add `public` declarations using `eval` #175

Closed lgoettgens closed 5 months ago

lgoettgens commented 5 months ago

Resolves the Tar.jl part of https://github.com/JuliaLang/julia/issues/51335 as suggested in https://github.com/JuliaIO/Tar.jl/pull/173#discussion_r1480230833.

Alternative to and thus closes #174.

This might have semantical conflicts with https://github.com/JuliaIO/Tar.jl/pull/173, so please re-run CI after merge of #173.

cc @LilithHafner @stevengj

stevengj commented 5 months ago

Those are the 6 things that are currently documented in the Tar.jl manual, so I think it's safe to say that they are public APIs.

lgoettgens commented 5 months ago

I just updated this to contain the merge commit of https://github.com/JuliaIO/Tar.jl/pull/173 to make sure to not accidentally break something.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (166deb3) 97.53% compared to head (2a96754) 97.53%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## ======================================= Coverage 97.53% 97.53% ======================================= Files 4 4 Lines 810 810 ======================================= Hits 790 790 Misses 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LilithHafner commented 5 months ago

@stevengj, I think this is ready to merge.