search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
79 stars 19 forks source link

macOS: apparently Sys.isexecutable is not reliable #87

Closed StefanKarpinski closed 3 years ago

StefanKarpinski commented 3 years ago

See https://github.com/JuliaLang/Pkg.jl/pull/2273. This is a real roller coaster. I would have naively thought that Sys.isexeccutable means the same thing as checking the user execute bit, but apparently not. It seems safer to assume that on non-Windows systems files we just created are never executable. This also avoids doing an unneccessary file stat on non-Windows systems.

codecov[bot] commented 3 years ago

Codecov Report

Merging #87 (715161a) into master (3ff3375) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files           4        4           
  Lines         637      637           
=======================================
  Hits          614      614           
  Misses         23       23
Impacted Files Coverage Δ
src/extract.jl 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ff3375...715161a. Read the comment docs.