search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
79 stars 19 forks source link

extract: always chmod files on extraction #88

Closed StefanKarpinski closed 3 years ago

StefanKarpinski commented 3 years ago

This is simpler and seems potentially more reliable than trying to reason about whether we need to call chmod or not: read the apparent mode (which may be inaccurate on some platforms), modify it as needed, then call chmod no matter what. Should be unnecessary on UNIX systems but harmless, sets the mode correctly even on systems where filemode and Sys.isexecutable may be unreliable.

codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (1a817fc) into master (c50caef) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   96.38%   96.37%   -0.02%     
==========================================
  Files           4        4              
  Lines         637      634       -3     
==========================================
- Hits          614      611       -3     
  Misses         23       23
Impacted Files Coverage Δ
src/extract.jl 96.26% <100.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c50caef...1a817fc. Read the comment docs.