search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
79 stars 19 forks source link

When extracting, don't use `filemode()` on windows #97

Closed staticfloat closed 3 years ago

staticfloat commented 3 years ago

Windows doesn't give realistic results from filemode(), so let's avoid using it to try and pick up umask-style environmental information, and just use the mode within the tarball.

codecov[bot] commented 3 years ago

Codecov Report

Merging #97 (6becdc9) into master (37766a2) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   96.37%   96.36%   -0.01%     
==========================================
  Files           4        4              
  Lines         634      633       -1     
==========================================
- Hits          611      610       -1     
  Misses         23       23
Impacted Files Coverage Δ
src/extract.jl 96.25% <100.00%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37766a2...6becdc9. Read the comment docs.

staticfloat commented 3 years ago

Alright got the tests passing locally. :)