search

JuliaIO / Tar.jl

TAR files: create, list, extract them in pure Julia
MIT License
79 stars 19 forks source link

Tar.extract: slight mode improvement #98

Closed StefanKarpinski closed 3 years ago

StefanKarpinski commented 3 years ago

The reason for using filemode to read the created mode was to respect the umask or equivalent mechanism for default permissions. Since the umask can only take permissions away, it is always correct to AND the default permissions with the desired permissions, since that will be more constrained than both the default and what the tarball requests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (222369b) into master (91a28ed) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files           4        4           
  Lines         633      633           
=======================================
  Hits          610      610           
  Misses         23       23
Impacted Files Coverage Δ
src/extract.jl 96.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91a28ed...222369b. Read the comment docs.