search

JuliaIO / TranscodingStreams.jl

Simple, consistent interfaces for any codec.
https://juliaio.github.io/TranscodingStreams.jl/
Other
86 stars 28 forks source link

Deprecate generic `seekend` method #198

Closed nhz2 closed 4 months ago

nhz2 commented 7 months ago

Ref: #183

mkitti commented 7 months ago

Use @deprecate.

help?> @deprecate
  @deprecate old new [export_old=true]

  Deprecate method old and specify the
  replacement call new, defining a new method
  old with the specified signature in the
  process.

  To prevent old from being exported, set
  export_old to false.
nhz2 commented 7 months ago

I'm not sure what new should be in this case.

nhz2 commented 7 months ago

Maybe it would be better not to deprecate and just remove the method in 0.11

I think the main reason for removing seekend is it enables things like: Try to seekend and if that works use a seeking strategy, otherwise, use a streaming strategy.

Also related https://github.com/JuliaLang/julia/issues/24242

mkitti commented 7 months ago

Well it would nice to make this compatible with --depwarn=true which should default to false for normal users.