search

JuliaIO / TranscodingStreams.jl

Simple, consistent interfaces for any codec.
https://juliaio.github.io/TranscodingStreams.jl/
Other
86 stars 28 forks source link

remove TestExt.jl #238

Closed nhz2 closed 2 months ago

nhz2 commented 2 months ago

Fixes #223 Fixes #234 Removes:

function test_roundtrip_read end
function test_roundtrip_write end
function test_roundtrip_transcode end
function test_roundtrip_lines end
function test_roundtrip_seekstart end
function test_roundtrip_fileio end
function test_chunked_read end
function test_chunked_write end

These functions have been moved into lib/TestsForCodecPackages in #235

I decided not to keep the functions as noops that always pass, because:

  1. I have already updated all usage of the functions I could find on JuliaHub. Ref: https://github.com/JuliaIO/CodecZlib.jl/pull/84 https://github.com/nhz2/CodecInflate64.jl/pull/2 https://github.com/JuliaIO/CodecXz.jl/pull/29 https://github.com/JuliaIO/CodecBase.jl/pull/17 https://github.com/JuliaIO/CodecZstd.jl/pull/61 https://github.com/JuliaIO/CodecBzip2.jl/pull/34 https://github.com/JuliaIO/CodecLz4.jl/pull/58
  2. These functions are not exported or documented, so they are not part of the API of this package.
  3. It is better for a no longer working testing function to fail loudly.