search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
128 stars 53 forks source link

Fixing C-wrap errors (AVIndexEntry) #115

Open timholy opened 6 years ago

timholy commented 6 years ago

I noticed that in AVIndexEntry, flags and size should be a bitfield union, and that our current struct (e.g., here) is therefore too large by one Cint. How would you like to fix this? Create patch files or directly edit the source?

kmsquire commented 5 years ago

Just noting that this is still an issue here.

I never answered @timholy's original message (sorry!), but I think that editing the source and creating a patch file (this is how the patch files were created) is the right way. That way, when someone tries to rerun the wrap script, they should "just" be able to apply the patch to get the corrected value.