search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Move to ffmpeg_jll backend #224

Closed IanButterworth closed 4 years ago

IanButterworth commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #224 into master will increase coverage by 0.39%. The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   74.86%   75.26%   +0.39%     
==========================================
  Files          14       14              
  Lines         569      566       -3     
==========================================
  Hits          426      426              
+ Misses        143      140       -3
Impacted Files Coverage Δ
src/avio.jl 76.00% <68.18%> (+0.36%) :arrow_up:
src/VideoIO.jl 52.27% <75.00%> (+1.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9974ba...25fcf3c. Read the comment docs.

IanButterworth commented 4 years ago

With the JLL switch, this PR is a little slower to load, but it seems ok.

This PR:

julia> @time using VideoIO
  5.443594 seconds (12.55 M allocations: 630.802 MiB, 2.69% gc time)

Master:

julia> @time using VideoIO
  3.774978 seconds (9.66 M allocations: 486.258 MiB, 1.85% gc time)
IanButterworth commented 4 years ago

When 1.5.0 is released, moving to FFMPEG_jll will be viable thanks to recent load time improvement 🎉

julia v1.4.1:
julia> @time using FFMPEG_jll
  3.401149 seconds (7.78 M allocations: 372.923 MiB, 4.28% gc time)

master compiled yesterday:
julia> @time using FFMPEG_jll
  1.105601 seconds (951.60 k allocations: 60.108 MiB, 0.88% gc time)

btw, thanks @giordano for running that test, and fixing a whole bunch of problems on ARMv7 JLLs

cc. @staticfloat @timholy