search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Allow encoding with rational frame rates #249

Closed galenlynch closed 4 years ago

galenlynch commented 4 years ago

While ffmpeg allows the use of rational frame rates, VideoIO.jl assumes that frame rates can only be integers. Many video capture devices do not have exactly integer frame rates, making it difficult to process their output with VideoIO.jl. I have therefore made simple modifications to the encoding code to allow rational frame rates.

codecov[bot] commented 4 years ago

Codecov Report

Merging #249 into master will increase coverage by 0.19%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   76.83%   77.02%   +0.19%     
==========================================
  Files          14       14              
  Lines         600      605       +5     
==========================================
+ Hits          461      466       +5     
  Misses        139      139
Impacted Files Coverage Δ
src/encoding.jl 90.97% <100.00%> (+0.27%) :arrow_up:
src/ffmpeg/AVUtil/src/AVUtil.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8849d0f...69bf5fd. Read the comment docs.

IanButterworth commented 4 years ago

Looks great, thanks for the addition and for the tests