Closed galenlynch closed 4 years ago
Merging #257 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 77.09% 77.09%
=======================================
Files 14 14
Lines 598 598
=======================================
Hits 461 461
Misses 137 137
Impacted Files | Coverage Δ | |
---|---|---|
src/avio.jl | 79.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d2166e5...d7d5e92. Read the comment docs.
CI failure here was a download blip
In
VideoReader
's constructor,aspect_ratio
is either set to the aspect ratio from the codec context, which is converted into aRational{Cint}
, or instead0 // 1
if the denominator is zero, which is aRational{Int}
. This causes unceccessary type instability, which can be fixed by instead makingaspect_ratio = Cint(0) // Cint(1)
if the denominator is zero.