search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Make some fields in `VideoReader` concrete types #258

Closed galenlynch closed 4 years ago

galenlynch commented 4 years ago

Two fields of VideoReader, framerate and aspect_ratio, are both of type Rational, an abstract type. In reality, the constructor of VideoReader sets both of these fields to be type Rational{Cint}. By changing the type definition to reflect that, it reduces type instability in code accessing VideoReader fields, while not restricting the generality of VideoReader.

codecov[bot] commented 4 years ago

Codecov Report

Merging #258 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files          14       14           
  Lines         598      598           
=======================================
  Hits          461      461           
  Misses        137      137
Impacted Files Coverage Δ
src/avio.jl 79.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2166e5...4f3e9b8. Read the comment docs.