search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Close file during path-based get_duration get_start_time get_time_duration #263

Closed IanButterworth closed 4 years ago

IanButterworth commented 4 years ago

Candidate fix for #262

@TheCedarPrince: If these tests pass, can you give this a go

codecov[bot] commented 4 years ago

Codecov Report

Merging #263 into master will increase coverage by 0.37%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   73.94%   74.31%   +0.37%     
==========================================
  Files          14       14              
  Lines         614      623       +9     
==========================================
+ Hits          454      463       +9     
  Misses        160      160
Impacted Files Coverage Δ
src/info.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d14edd...c142cdd. Read the comment docs.

TheCedarPrince commented 4 years ago

Can confirm that this fixes my issue! Feel free to merge! Thank you for the help @ianshmean :smile:

I forked and checked out to this branch and now all my tests pass. :+1: