search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Should we test VideoIO using the ffmpeg and ffprobe binaries? #272

Open galenlynch opened 3 years ago

galenlynch commented 3 years ago

It seems like a lot of the testing of VideoIO is only making sure that its behavior is consistent and not that its behavior is correct. By this I mean that the testing code compares VIdeoIO's behavior to values that were likely generated using VideoIO itself. In #270 it seems like the "right" number of frames in the test videos, and generated videos, was determined using VideoIO itself. Similarly in #271 the behavior of VideoIO was assumed to be correct, and even written in a comment. There may be other examples like this lurking in the test code.

Instead of circularly validating VideoIO with itself, maybe we should rely on the ffprobe and ffmpeg binaries to give us target performance, e.g. by writing frames to picture files and then using ffmpeg to encode a "reference" video which will be used to validate VideoIO's encoding.

IanButterworth commented 3 years ago

Great idea 👍

IanButterworth commented 3 years ago

I believe this is implemented now?

IanButterworth commented 3 years ago

Bump @galenlynch We can close this, right?