search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
128 stars 53 forks source link

Remove 'archived' gen files #286

Closed galenlynch closed 3 years ago

galenlynch commented 3 years ago

These files do not appear to be used, nor do they seem to have been used to generate the libav/ffmpeg bindings in VideoIO.

In case they really are just "archive" code, and not needed for something else, I am submitted this PR to remove them.

codecov[bot] commented 3 years ago

Codecov Report

Merging #286 (dcbdd84) into master (c128fca) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files          14       14           
  Lines         594      594           
=======================================
  Hits          452      452           
  Misses        142      142

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c128fca...dcbdd84. Read the comment docs.

IanButterworth commented 3 years ago

We can always retrieve these from the history anyway, so I think you're right to suggest removing them