search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

why the pwd? #288

Closed yakir12 closed 3 years ago

yakir12 commented 3 years ago

https://github.com/JuliaIO/VideoIO.jl/blob/67e7a6dc811338d86f8d09ac2cb96c9dfaf00ec8/src/encoding.jl#L228

why report that "Video file saved: $(pwd())/$destfilename" and not "Video file saved: $destfilename"? You're also assuming that the OS has a / for paths. Threw me off at least. Or maybe there is a good reason for it?

IanButterworth commented 3 years ago

Good question. Looks to be in error. Perhaps it's just catering for if only a file name is provided, not a path.

yakir12 commented 3 years ago

I see. Well, since that is not what the function does (i.e. it does not create a video at joinpath(pwd(), destfilename) nor does it delete a file at joinpath(pwd(), srcfilename), then I suggest we remove that (PR #289).