Should `pump` be exported?

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg

https://juliaio.github.io/VideoIO.jl/stable

Other

126 stars 53 forks source link

Should `pump` be exported? #293

Open galenlynch opened 3 years ago

galenlynch commented 3 years ago

This function is currently exported, but seems like a function that's used for the internal plumbing of VideoReader, rather than something that's a necessary part of the API. Perhaps it should not be exported?

IanButterworth commented 3 years ago

Agreed. Seems odd. Shall we change for v0.9?

galenlynch commented 3 years ago

Yeah sounds good.

IanButterworth commented 3 years ago

Did this slip through?