search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

Create CHANGELOG.md and document v0.9 changes #306

Closed IanButterworth closed 3 years ago

IanButterworth commented 3 years ago

@galenlynch feel free to PR against this to add/edit

codecov[bot] commented 3 years ago

Codecov Report

Merging #306 (c07ff34) into master (903ba67) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          17       17           
  Lines        1196     1196           
=======================================
  Hits          985      985           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 903ba67...c07ff34. Read the comment docs.

IanButterworth commented 3 years ago

Thought.. perhaps it should be push_encode_mux! given Base.push! adds an item to a collection, whereas Base.append! adds a collection to a collection

Also.. maybe we skip mux in the name aswell? push_encode!?

Or just extend push!??

Trying it out over here https://github.com/JuliaIO/VideoIO.jl/pull/307

IanButterworth commented 3 years ago

Closing as I accidentally added the changelog to https://github.com/JuliaIO/VideoIO.jl/pull/307, so let's consolidate there given the API changes proposed