IanButterworth commented 3 years ago

Needed to lock into FileIO's load and save interface

IanButterworth commented 3 years ago

Turns out tests are failing on 1.3 with this, which I can't yet figure out. I'll get this merged and try to fix in another PR

Reading annie_oakley.ogg: Error During Test at /Users/ian/Documents/GitHub/VideoIO.jl/test/reading.jl:6
  Got exception outside of a @test
  MethodError: no method matching #VideoReader#18(::Bool, ::Nothing, ::Int64, ::Nothing, ::Bool, ::NamedTuple{(:sws_flags,),Tuple{String}}, ::Nothing, ::Type{VideoIO.VideoReader}, ::VideoIO.AVInput{String}, ::Int64)
  Closest candidates are:
    #VideoReader#18(::Bool, ::Union{Nothing, Int32}, ::Any, ::Any, ::Any, ::Union{AbstractDict{Union{},Union{}}, AbstractDict{Symbol,#s200} where #s200, NamedTuple}, !Matched::Union{AbstractDict{Union{},Union{}}, AbstractDict{Symbol,#s200} where #s200, NamedTuple}, ::Type{VideoIO.VideoReader}, ::VideoIO.AVInput{I}, ::Any) where I at /Users/ian/Documents/GitHub/VideoIO.jl/src/avio.jl:252
  Stacktrace:
   [1] (::Core.var"#kw#Type")(::NamedTuple{(:swscale_options,),Tuple{NamedTuple{(:sws_flags,),Tuple{String}}}}, ::Type{VideoIO.VideoReader}, ::VideoIO.AVInput{String}, ::Int64) at ./none:0 (repeats 2 times)
   [2] #openvideo#20(::Base.Iterators.Pairs{Symbol,NamedTuple{(:sws_flags,),Tuple{String}},Tuple{Symbol},NamedTuple{(:swscale_options,),Tuple{NamedTuple{(:sws_flags,),Tuple{String}}}}}, ::typeof(VideoIO.openvideo), ::VideoIO.AVInput{String}) at /Users/ian/Documents/GitHub/VideoIO.jl/src/avio.jl:588
   [3] (::VideoIO.var"#kw##openvideo")(::NamedTuple{(:swscale_options,),Tuple{NamedTuple{(:sws_flags,),Tuple{String}}}}, ::typeof(VideoIO.openvideo), ::VideoIO.AVInput{String}) at ./none:0
   [4] top-level scope at /Users/ian/Documents/GitHub/VideoIO.jl/test/reading.jl:10
   [5] top-level scope at /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [6] top-level scope at /Users/ian/Documents/GitHub/VideoIO.jl/test/reading.jl:7
   [7] top-level scope at /Users/julia/buildbot/worker/package_macos64/build/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [8] top-level scope at /Users/ian/Documents/GitHub/VideoIO.jl/test/reading.jl:2
   [9] include at ./boot.jl:328 [inlined]
   [10] include_relative(::Module, ::String) at ./loading.jl:1105
   [11] include(::Module, ::String) at ./Base.jl:31
   [12] include(::String) at ./client.jl:424
   [13] top-level scope at /Users/ian/Documents/GitHub/VideoIO.jl/test/runtests.jl:22
   [14] include at ./boot.jl:328 [inlined]
   [15] include_relative(::Module, ::String) at ./loading.jl:1105
   [16] include(::Module, ::String) at ./Base.jl:31
   [17] include(::String) at ./client.jl:424
   [18] top-level scope at none:6
   [19] eval(::Module, ::Any) at ./boot.jl:330
   [20] exec_options(::Base.JLOptions) at ./client.jl:263
   [21] _start() at ./client.jl:460

codecov[bot] commented 3 years ago

Codecov Report

Merging #311 (1ae9b09) into master (9cdbdee) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   81.42%   81.45%   +0.03%     
==========================================
  Files          17       17              
  Lines        1179     1181       +2     
==========================================
+ Hits          960      962       +2     
  Misses        219      219

Impacted Files	Coverage Δ
src/VideoIO.jl	`54.34% <100.00%> (+2.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cdbdee...1ae9b09. Read the comment docs.

JuliaIO / VideoIO.jl

add FileIO interface for load and save #311

Codecov Report