IanButterworth commented 3 years ago

@galenlynch this appears to be a typo. Can you confirm?

Evidently our tests aren't covering this branch.

Fixes https://github.com/JuliaIO/VideoIO.jl/issues/313

codecov[bot] commented 3 years ago

Codecov Report

Merging #314 (e42c547) into master (7709189) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   81.45%   81.45%           
=======================================
  Files          17       17           
  Lines        1181     1181           
=======================================
  Hits          962      962           
  Misses        219      219

Impacted Files	Coverage Δ
src/avio.jl	`81.34% <0.00%> (ø)`
src/frame_graph.jl	`99.18% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7709189...e42c547. Read the comment docs.

galenlynch commented 3 years ago

Whoops my bad. That is definitely a typo, but the correct value is bit_depth, not padded_bits_per_pixel. I'll make a PR against your branch.

IanButterworth commented 2 years ago

@galenlynch this slipped through. Do you recall if it's still correct? I assume so, but confirmation would be appreciated

galenlynch commented 2 years ago

Hey sorry I've been AWOL. Will check it today.

JuliaIO / VideoIO.jl

Fix typo for bit_depth #314

Codecov Report