JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
126 stars 53 forks source link

ERROR: type VideoReader has no field height #319

Open adomasbaliuka opened 3 years ago

adomasbaliuka commented 3 years ago

I wanted to try the example given at the docs. However, it doesn't seem to work. Either this is a bug or the docs would benefit a lot from an example that can be "copy pasted into somewhere" and just works.

julia> using Pkg; Pkg.status()
Status `~/git/ML/tmp-issue/Project.toml`
  [ee78f7c6] Makie v0.12.0
  [d6d074c3] VideoIO v0.9.1

julia> using Makie

julia> using VideoIO

julia> f = VideoIO.testvideo("annie_oakley")  # downloaded if not available
AVInput(/home/alice/.julia/packages/VideoIO/B6VOI/src/../videos/annie_oakley.ogg, ...), with
  1 video stream(s)

julia> VideoIO.playvideo(f)  # no sound
ERROR: type VideoReader has no field height
Stacktrace:
 [1] getproperty(::VideoIO.VideoReader{true,VideoIO.SwsTransform,String}, ::Symbol) at ./Base.jl:33
 [2] play(::VideoIO.VideoReader{true,VideoIO.SwsTransform,String}; flipx::Bool, flipy::Bool, pixelaspectratio::Nothing) at /home/alice/.julia/packages/VideoIO/B6VOI/src/VideoIO.jl:140
 [3] playvideo(::VideoIO.AVInput{String}; flipx::Bool, flipy::Bool, pixelaspectratio::Nothing) at /home/alice/.julia/packages/VideoIO/B6VOI/src/VideoIO.jl:163
 [4] playvideo(::VideoIO.AVInput{String}) at /home/alice/.julia/packages/VideoIO/B6VOI/src/VideoIO.jl:162
 [5] top-level scope at REPL[8]:1

julia> VERSION
v"1.5.3"
IanButterworth commented 3 years ago

Ah, that function is an extra that's not covered by tests hence appears to have broken in the v0.9 update.

It should work with v0.8

We should fix it and either add it to the test suite, or remove it in the next breaking release, and finish one of the video viewer packages that have been started in the past