search

JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
128 stars 53 forks source link

Skip creation of zoom,etc, callbacks in ImageView #33

Closed timholy closed 10 years ago

timholy commented 10 years ago

This increases the performance substantially, at least for small videos. At least in other contexts, this also solves a weird memory problem https://github.com/timholy/ImageView.jl/issues/32. But my tests with VideoIO suggest the memory usage slowly grows over time. I'm not sure why that's happening.

Presumably the best solution is to pass the whole movie to ImageView as an object, so if you don't want to merge this, that's fine.

kmsquire commented 10 years ago

It might take a little time to get to passing the movie to ImageView as an object, so this seems worthwhile for now.

I recently included ImageView in REQUIRE, so I updated the required version there. (Optional requirements would be nice here--e.g., if ImageView is installed, we need at least version 0.1.4, but it's not required. I think I'll file an issue, at least for discussion.)

The Travis failure is unrelated (I filed a Coverage.jl issue separately).