JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
125 stars 53 forks source link

Formatting: apply JuliaFormatter and add formatter PR bot #353

Closed IanButterworth closed 2 years ago

IanButterworth commented 2 years ago

I thought it would be worth conforming the formatting in the human-generated codebase via JuliaFormatter

This formats that code, and sets up a bot that formats any open PRs and opens PRs against that PR if any formatting fixes are found.

codecov[bot] commented 2 years ago

Codecov Report

Merging #353 (b9914ff) into master (3bd9b82) will decrease coverage by 0.01%. The diff coverage is 79.34%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   78.81%   78.80%   -0.02%     
==========================================
  Files          10       10              
  Lines        1251     1250       -1     
==========================================
- Hits          986      985       -1     
  Misses        265      265              
Impacted Files Coverage Δ
src/VideoIO.jl 18.18% <0.00%> (ø)
src/avdictionary.jl 0.00% <0.00%> (ø)
src/avio.jl 76.95% <70.45%> (-0.06%) :arrow_down:
src/avptr.jl 69.56% <80.00%> (ø)
src/testvideos.jl 73.80% <83.33%> (ø)
src/avframe_transfer.jl 81.86% <87.50%> (ø)
src/encoding.jl 93.33% <97.56%> (ø)
src/frame_graph.jl 99.23% <100.00%> (ø)
src/info.jl 100.00% <100.00%> (ø)
src/util.jl 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bd9b82...b9914ff. Read the comment docs.

IanButterworth commented 2 years ago

@galenlynch you mentioned being supportive of this kind of thing, but I wanted to check. Thanks

IanButterworth commented 2 years ago

Friendly bump. Given the size of the diff here, I'd like to get a second opinion 🙏🏻

IanButterworth commented 2 years ago

In lieu of a review, I'll merge at the end of this week