JuliaIO / VideoIO.jl

Reading and writing of video files in Julia via ffmpeg
https://juliaio.github.io/VideoIO.jl/stable
Other
125 stars 53 forks source link

update sample code to latest Makie API fix #354 #355

Closed FelipeLema closed 2 years ago

FelipeLema commented 2 years ago

show_axis & scale_plot no longer supported

fixes #354

codecov[bot] commented 2 years ago

Codecov Report

Merging #355 (bcdd758) into master (294f94f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files          10       10           
  Lines        1253     1253           
=======================================
  Hits          985      985           
  Misses        268      268           
Impacted Files Coverage Δ
src/VideoIO.jl 18.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 294f94f...bcdd758. Read the comment docs.

IanButterworth commented 2 years ago

@FelipeLema I hope you don't mind, I pushed some more fixes for the docs and viewcam.

Would you mind testing whether viewcam() works for you? On MacOS for me it loads and grabs images but nothing shows in the Makie window.

FelipeLema commented 2 years ago

it shows a blank screen to me too. Let me have a go at it

FelipeLema commented 2 years ago

It properly shows a x-flipped image from my webcam (mimics a mirror)

there are some other details (provided width & height is ignored), but I guess we can go with this one in the meantime

shoutouts to macOS' GateKeeper for quietly blocking me on this one for so long

FelipeLema commented 2 years ago

I dunno what's up with format linter, but this is ready to go

IanButterworth commented 2 years ago

Thanks I'll test locally and fix the formatter (this is the first PR after I added that, so it's good to fix it)