Open IanButterworth opened 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
755ad16
) 79.43% compared to head (7f2c717
) 79.43%.:exclamation: Current head 7f2c717 differs from pull request most recent head 7eb87fc. Consider uploading reports for the commit 7eb87fc to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
results from this https://github.com/JuliaIO/VideoIO.jl/pull/393/commits/7f2c7173addc2f2cc31594bca4512bae8e7049e0 :
julia> VideoIO.framerate.(VideoIO.openvideo.(fnames))
5-element Vector{Rational{Int32}}:
1//90000
1//12800
1//15360
1//1000
1//25000
julia> map(fnames) do x
vid=VideoIO.openvideo(x); read(vid); VideoIO.framerate(vid)
end
5-element Vector{Rational{Int32}}:
1//90000
1//12800
1//15360
1//1000
1//25000
julia> get_fps.(fnames)
5-element Vector{Rational{Int64}}:
30//1
25//1
30//1
25//1
25//1
@AbelHo @f3fora would you mind reviewing this. I can't see why the tests are failing
Bump @AbelHo (I saw the thumbs up. Thanks!)
Bump. Help would be appreciated 🙏
Related to #392
Todo:
cc. @AbelHo