search

JuliaImageRecon / ImagePhantoms.jl

Software phantoms for image reconstruction
MIT License
11 stars 4 forks source link

Major overhaul to improve types #38

Closed JeffFessler closed 2 years ago

JeffFessler commented 2 years ago

Should address #30 and simplifies a lot of construction code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (438c041) into main (507d9f5) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          487       449   -38     
=========================================
- Hits           487       449   -38
Impacted Files Coverage Δ
src/cuboid.jl 100.00% <100.00%> (ø)
src/ellipse.jl 100.00% <100.00%> (ø)
src/ellipsoid.jl 100.00% <100.00%> (ø)
src/focus-chart.jl 100.00% <100.00%> (ø)
src/gauss2.jl 100.00% <100.00%> (ø)
src/gauss3.jl 100.00% <100.00%> (ø)
src/object.jl 100.00% <100.00%> (ø)
src/object2.jl 100.00% <100.00%> (ø)
src/object3.jl 100.00% <100.00%> (ø)
src/rect.jl 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 507d9f5...438c041. Read the comment docs.

JeffFessler commented 2 years ago

@johnnychen94, your suggestion led to this big overhaul, and it really improved things I think. I might make some further refinements. Any comments on this version?