JuliaImageRecon / ImagePhantoms.jl

Software phantoms for image reconstruction
MIT License
11 stars 4 forks source link

Fix 3D Shepp Logan value bug #71

Closed JeffFessler closed 1 year ago

JeffFessler commented 1 year ago

Addresses #70 by fixing a bug in ellipsoid_parameters_uscale that arose from adding the 3rd rotation angle in #58 and not quite propagating that everywhere.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (7d352e2) compared to base (0c995ab). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 592 594 +2 ========================================= + Hits 592 594 +2 ``` | [Impacted Files](https://codecov.io/gh/JuliaImageRecon/ImagePhantoms.jl/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/shepplogan.jl](https://codecov.io/gh/JuliaImageRecon/ImagePhantoms.jl/pull/71/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NoZXBwbG9nYW4uamw=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.