JuliaImageRecon / RegularizedLeastSquares.jl

MIT License
20 stars 9 forks source link

Nd total variation #48

Closed JakobAsslaender closed 1 year ago

JakobAsslaender commented 1 year ago

Hi @migrosser and @tknopp,

I developed this code a bit further. The key changes are:

The part that bothers me the most is that you cannot dispatch on keyword arguments and I am dispatching over dims to choose the Condat or the FDG algorithm. And we do need keyword arguments with the current wrapper functions of your regularizer setup. The hack to fix this is to have a function call with keyword arguments as a wrapper and then dispatch w/o keywords. Ain't pretty--let me know if you have a better idea.

migrosser commented 1 year ago

To me the PR looks quite nice. Concerning the dispatch over dims, the function barrier you implemented is probably the most elegant workaround, which doesn't require any breaking changes of our regularizer interface.