Package conflict with function `factor`

JuliaImageRecon / RegularizedLeastSquares.jl

MIT License

20 stars 9 forks source link

Package conflict with function `factor` #61

Closed JakobAsslaender closed 9 months ago

JakobAsslaender commented 9 months ago

Hi! Would it be possible to rename (or not export) the function factor? It conflicts with Primes.jl where the function calculates the factors of an integer.

julia> using Primes
julia> using RegularizedLeastSquares
julia> factor
WARNING: both Primes and RegularizedLeastSquares export "factor"; uses of it in module Main must be qualified
ERROR: UndefVarError: `factor` not defined

I personally would also find it helpful to have a more descriptive function name.

Many thanks! -ja

nHackel commented 9 months ago

Helllo!

Yes, we can do that. I just renamed the function and also removed the export. Once the public keyword in Julia becomes available we will use that for functions like this, which are not intended to be directly used by users but are for developers adding their own reg. terms

nHackel commented 9 months ago

This was closed with version 0.11.2