search

JuliaImageRecon / RegularizedLeastSquares.jl

MIT License
20 stars 9 forks source link

[Bug] ADMM is never converged #91

Open JakobAsslaender opened 1 month ago

JakobAsslaender commented 1 month ago

@nHackel:

I am not sure if I am overlooking something, but you changed the output of the ADMM converged function to always return false:

https://github.com/JuliaImageRecon/RegularizedLeastSquares.jl/blob/06c8405535b2cca63c7b638cf8d003d1fcecc490/src/ADMM.jl#L284

I presume this is a bug and should be reverted to return true after the for loop, if it gets there, right?

nHackel commented 1 month ago

Oh yes, that is definitely not intentional :see_no_evil:

nHackel commented 1 month ago

I'll fix that on the master real quick

nHackel commented 1 month ago

Maybe we should add convergence tests. Just a small problem with an "excessive" number of iterations and then we check afterwards if it converged