search

JuliaImages / DitherPunk.jl

Dithering algorithms in Julia.
MIT License
68 stars 3 forks source link

Add reference tests #12

Closed adrhill closed 3 years ago

adrhill commented 3 years ago

closes #11

adrhill commented 3 years ago

@johnnychen94 Any idea on how to make this work on Julia 1.0?

Converting function names to strings with "$(alg)" seems to add the module name under Julia 1.0, silently leading false positive tests, e.g.

┌ Info: Reference file for "grad_DitherPunk.threshold_dithering.txt" did not exist. It has been created
└   new_reference = "/home/runner/work/DitherPunk.jl/DitherPunk.jl/test/references/grad_DitherPunk.threshold_dithering.txt"

where it should have been grad_threshold_dithering.txt.

The reference test grad_bayer_dithering_l2.txt seems to fail because the returned BitMatrix consists of true/false rather than 1/0. I'm not sure why ReferenceTests makes a distinction.

codecov-commenter commented 3 years ago

Codecov Report

Merging #12 (16d8e3d) into master (9341239) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files           7        7           
  Lines         104      104           
=======================================
  Hits           97       97           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9341239...16d8e3d. Read the comment docs.

adrhill commented 3 years ago

Thanks @johnnychen94 ! 🥳